Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add topology spread constraints to mesh term and ingress gw #1257

Merged
merged 5 commits into from
Jun 6, 2022

Conversation

kschoche
Copy link
Contributor

@kschoche kschoche commented Jun 3, 2022

Changes proposed in this PR:

  • Adds ability to specify pod TopologySpreadConstraints for the mesh/term/ingress gateways, modeled off of the way that we are able to currently specify it in the server-statefulset.

https://kubernetes.io/docs/concepts/workloads/pods/pod-topology-spread-constraints/

How I've tested this PR:
🦇 test.

How I expect reviewers to test this PR:
👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@kschoche kschoche added type/enhancement New feature or request area/chart-only Related to changes that simply require yaml Helm chart changes, e.g. exposing a new field labels Jun 3, 2022
@kschoche kschoche requested a review from a team June 3, 2022 16:56
@kschoche kschoche self-assigned this Jun 3, 2022
@kschoche kschoche requested review from ndhanushkodi and thisisnotashwin and removed request for a team June 3, 2022 16:56
charts/consul/test/unit/ingress-gateways-deployment.bats Outdated Show resolved Hide resolved
--set 'ingressGateways.enabled=true' \
--set 'connectInject.enabled=true' \
. | tee /dev/stderr |
yq '.spec.template.spec | .topologySpreadConstraints? == null' | tee /dev/stderr)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about .key?! nice find

Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EXCELLENT!

Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>
@kschoche kschoche merged commit 4b630fc into main Jun 6, 2022
@kschoche kschoche deleted the add_topology_spread_constraints_mesh_term_gw branch June 6, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/chart-only Related to changes that simply require yaml Helm chart changes, e.g. exposing a new field type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants