Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Peer field to Intention CRD source intention #1263

Merged
merged 4 commits into from
Jun 10, 2022

Conversation

ndhanushkodi
Copy link
Contributor

@ndhanushkodi ndhanushkodi commented Jun 8, 2022

Changes proposed in this PR:

  • Add peer field to intention CRD
  • Bump api module

How I've tested this PR:

  • unit tests

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@ndhanushkodi ndhanushkodi changed the base branch from main to peering June 8, 2022 16:44
@ndhanushkodi ndhanushkodi changed the title Add Peer field Intention CRD source intention Add Peer field to Intention CRD source intention Jun 8, 2022
@ndhanushkodi ndhanushkodi requested review from thisisnotashwin, a team and t-eckert and removed request for a team June 10, 2022 16:28
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EXCELLENT!!

@ndhanushkodi ndhanushkodi merged commit 5dff96a into peering Jun 10, 2022
@ndhanushkodi ndhanushkodi deleted the peering-intention-crd branch June 10, 2022 23:23
ndhanushkodi added a commit that referenced this pull request Jun 13, 2022
update source intentions with peer name and bump api module and change initiate -> establish
ndhanushkodi added a commit that referenced this pull request Jun 13, 2022
update source intentions with peer name and bump api module and change initiate -> establish
ndhanushkodi added a commit that referenced this pull request Jun 13, 2022
update source intentions with peer name and bump api module and change initiate -> establish
ndhanushkodi added a commit that referenced this pull request Jun 13, 2022
update source intentions with peer name and bump api module and change initiate -> establish
ndhanushkodi added a commit that referenced this pull request Jun 15, 2022
update source intentions with peer name and bump api module and change initiate -> establish
thisisnotashwin pushed a commit that referenced this pull request Jun 16, 2022
update source intentions with peer name and bump api module and change initiate -> establish
thisisnotashwin pushed a commit that referenced this pull request Jun 16, 2022
update source intentions with peer name and bump api module and change initiate -> establish
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants