Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog peering #1279

Merged
merged 2 commits into from
Jun 15, 2022
Merged

Changelog peering #1279

merged 2 commits into from
Jun 15, 2022

Conversation

ndhanushkodi
Copy link
Contributor

Checklist:

  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

thisisnotashwin
thisisnotashwin approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent! Should we set this PR against the peering branch? we can then merge it into that branch and then merge the entire thing into main!

@ndhanushkodi ndhanushkodi changed the base branch from main to peering June 15, 2022 16:43
@ndhanushkodi ndhanushkodi merged commit 1981735 into peering Jun 15, 2022
@ndhanushkodi ndhanushkodi deleted the changelog-peering branch June 15, 2022 16:49
thisisnotashwin pushed a commit that referenced this pull request Jun 16, 2022
@ndhanushkodi @thisisnotashwin
Add changelog for cluster peering (#1279)
4d703ad
thisisnotashwin pushed a commit that referenced this pull request Jun 16, 2022
@ndhanushkodi @thisisnotashwin
Add changelog for cluster peering (#1279)
430e52f
thisisnotashwin pushed a commit that referenced this pull request Jun 16, 2022
@ndhanushkodi @thisisnotashwin
Add changelog for cluster peering (#1279)
136d312
thisisnotashwin added a commit that referenced this pull request Jun 16, 2022
@thisisnotashwin
Revert "Add changelog for cluster peering (#1279)"
f96dee3 
This reverts commit 136d312.
thisisnotashwin added a commit that referenced this pull request Jun 16, 2022
@thisisnotashwin
Revert "Add changelog for cluster peering (#1279)" (#1286)
1a89899 
This reverts commit 136d312.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishustava ishustava ishustava approved these changes

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ndhanushkodi @ishustava @thisisnotashwin