Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests #1313

Merged
merged 6 commits into from
Jul 6, 2022
Merged

Tests #1313

merged 6 commits into from
Jul 6, 2022

Commits on Jul 4, 2022

  1. fix dataDirectoryHostPath tests 

    Assuming that volumes will always be at a fixed positions in a list
volumes won't work in the long run. Use `select(.name ...` to find
them.
    @eb4x
    eb4x committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    7e76901 View commit details
    Browse the repository at this point in the history

  2. fix test comparison 

    There's no ${actual} here, only ${object} to compare with.
    @eb4x
    eb4x committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    fd84db2 View commit details
    Browse the repository at this point in the history

  3. select named initContainers 

    Assuming that initContainers will always be at a fixed positions in
a list won't work in the long run. Use `select(.name ...` to find
them.
    @eb4x
    eb4x committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    878741e View commit details
    Browse the repository at this point in the history

  4. simplify yq queries 

    swap map for []
    @eb4x
    eb4x committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    09f6bbc View commit details
    Browse the repository at this point in the history

  5. check all of env for CONSUL_HTTP_TOKEN_FILE 

    This test was probably meant to check all items in the env for
CONSUL_HTTP_TOKEN_FILE and not just the first entry.

Also, find the container named consul rather than assuming it's the
first in the list.
    @eb4x
    eb4x committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    62edc36 View commit details
    Browse the repository at this point in the history

  6. Re-word tests with has("securityContext") 

    I think this improves the readability of the tests.
    @eb4x
    eb4x committed Jul 4, 2022
    Configuration menu
    Copy the full SHA
    7178b99 View commit details
    Browse the repository at this point in the history