Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Destination Field to Service-Defaults for Tproxy Egress #1352

Merged
merged 3 commits into from
Jul 28, 2022

Conversation

DanStough
Copy link
Member

Changes proposed in this PR:

  • Adds the "Destination" field to the "ServiceDefaults" CRD spec to be consistent with the consul core API. This enables external mesh traffic to be routed through terminating gateways in transparent mode.
  • Minor CONTRIBUTING update based on first-time contributor experience.

How I've tested this PR:

Short version (detailed test plan available upon request)

  • Build control-plane
  • Deploy through Helm chart to local cluster w/ transparent proxy enabled and dev image override.
  • Add static-client application
  • Add service-default CRD w/ destination to "httpbin.org:443"
  • Add mesh CRD with "meshDestinationsOnly" enabled
  • Add terminating gateway CRD w/ link to "httpbin" service default
  • Exec into client pod and "curl https://httpbin.org/uuid"

Acceptance Tests(?): TBD

How I expect reviewers to test this PR:

  • Something similar to the above process.

Checklist:
TBD Below

  • Tests added
  • CHANGELOG entry added

@DanStough
Copy link
Member Author

Looks like there is some weirdness w/ the new SDK update. Will investigate.

acceptance/go.mod Outdated Show resolved Hide resolved
@DanStough DanStough marked this pull request as ready for review July 19, 2022 18:45
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent!! Have a comment that should be straightforward to address, but excellent work!!

charts/consul/templates/crd-peeringacceptors.yaml Outdated Show resolved Hide resolved
control-plane/api/v1alpha1/servicedefaults_types.go Outdated Show resolved Hide resolved
@DanStough DanStough force-pushed the dstough/CSLC-136/tproxy-destinations branch from de21e88 to c7376e6 Compare July 26, 2022 14:14
@DanStough DanStough requested review from a team and ishustava and removed request for a team July 26, 2022 14:42
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Dan!! This looks fantastic! Just a few minor comments.

CHANGELOG.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@DanStough DanStough force-pushed the dstough/CSLC-136/tproxy-destinations branch from c7376e6 to 3a5660a Compare July 27, 2022 16:21
@DanStough DanStough merged commit d3b38de into main Jul 28, 2022
@DanStough DanStough deleted the dstough/CSLC-136/tproxy-destinations branch July 28, 2022 13:49
@DanStough DanStough mentioned this pull request Jul 28, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants