peering: remove unnecessary expose servers service, add error cases, fix flaky test #1683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndhanushkodi
requested review from
a team,
jmurret and
ishustava
and removed request for
a team
ndhanushkodi
changed the title
ndhanushkodi
changed the title
ishustava
approved these changes
Nov 8, 2022
CHANGELOG.md
Outdated
Comment on lines
15
to
16
| * Enabling peering requires `global.tls.enabled`. [[GH-1610](https://github.com/hashicorp/consul-k8s/pull/1610)] | ||
| * Enabling peering requires `meshGateway.enabled`. [[GH-1683](https://github.com/hashicorp/consul-k8s/pull/1683)] |
There was a problem hiding this comment.
nit: could we rephrase to be "verb ..." so "Require global.tls.enabled when peering is enabled" 🙏
CHANGELOG.md
Outdated
| @@ -34,6 +35,7 @@ IMPROVEMENTS: | |||
| * API Gateway: Add `tolerations` to `apiGateway.managedGatewayClass` and `apiGateway.controller` [[GH-1650](https://github.com/hashicorp/consul-k8s/pull/1650)] | |||
| * API Gateway: Create PodSecurityPolicy for controller when `global.enablePodSecurityPolicies=true`. [[GH-1656](https://github.com/hashicorp/consul-k8s/pull/1656)] | |||
| * API Gateway: Create PodSecurityPolicy and allow controller to bind it to ServiceAccounts that it creates for Gateway Deployments when `global.enablePodSecurityPolicies=true`. [[GH-1672](https://github.com/hashicorp/consul-k8s/pull/1672)] | |||
| * Expose servers service is only deployed when Admin Partitions(ENT) is enabled. [[GH-1683](https://github.com/hashicorp/consul-k8s/pull/1683)] | |||
There was a problem hiding this comment.
Same here:
Suggested change
| * Expose servers service is only deployed when Admin Partitions(ENT) is enabled. [[GH-1683](https://github.com/hashicorp/consul-k8s/pull/1683)] | |
| * Deploy `expose-servers` service only when Admin Partitions(ENT) is enabled. [[GH-1683](https://github.com/hashicorp/consul-k8s/pull/1683)] |
There was a problem hiding this comment.
The suggestion above has the word . NVM, as admin, I could modify someone else's suggestion. 😬deploy(ed) twice.
jmurret
approved these changes
Nov 8, 2022
ndhanushkodi
force-pushed
the
nd/peering-improvements
branch
from
30b5a46
to
796a0c7
Compare
…s are included remove expose server service when peering is enabled, add more error msgs
ndhanushkodi
force-pushed
the
nd/peering-improvements
branch
from
796a0c7
to
a5d4284
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
acceptance tests, unit tests
How I expect reviewers to test this PR:
👀
Checklist: