Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for node meta field #1707

Merged
merged 1 commit into from Nov 14, 2022
Merged

Add support for node meta field #1707

merged 1 commit into from Nov 14, 2022

Conversation

thisisnotashwin
Copy link
Contributor

@thisisnotashwin thisisnotashwin commented Nov 14, 2022 •
edited by curtbushko

Changes proposed in this PR:

  • Add connectInject.consulNode.meta to values file to allow users to provide custom metadata to append to the NodeMeta. Pipe those values through into the NodeMeta of the service and proxy registrations for both services and gateways.

How I've tested this PR:

  • Unit tests and bats tests.

How I expect reviewers to test this PR:

  • 馃憖

Does this need a changelog?

Checklist:

  • Tests added
  • CHANGELOG entry added in CHANGELOG updates for 1.0聽#1727

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

ishustava
ishustava approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

curtbushko
curtbushko approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@thisisnotashwin thisisnotashwin merged commit 9a3bef9 into main Nov 14, 2022
@thisisnotashwin thisisnotashwin deleted the ashwin/node-meta branch November 14, 2022 18:18
@natitomattis natitomattis mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtbushko curtbushko curtbushko approved these changes

@ishustava ishustava ishustava approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thisisnotashwin @curtbushko @ishustava