Added support for go-changelog automations #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilkermichael
force-pushed
the
add-go-changelog
branch
3 times, most recently
from
0ccd45d
to
ba13e72
Compare
wilkermichael
added
the
pr/no-changelog
wilkermichael
force-pushed
the
add-go-changelog
branch
from
ba13e72
to
6f5043f
Compare
wilkermichael
requested review from
a team,
curtbushko,
hashi-derek,
david-yu and
thisisnotashwin
and removed request for
a team and
curtbushko
wilkermichael
changed the title
hashi-derek
approved these changes
Feb 23, 2023
wilkermichael
force-pushed
the
add-go-changelog
branch
from
6f5043f
to
3fc44d5
Compare
david-yu
approved these changes
Feb 23, 2023
wilkermichael
added
backport/0.49.x
|
Regardless of state, I won't merge this until 1.1 is released |
wilkermichael
force-pushed
the
add-go-changelog
branch
from
3fc44d5
to
a654c4c
Compare
curtbushko
approved these changes
Feb 24, 2023
thisisnotashwin
approved these changes
Feb 24, 2023
wilkermichael
force-pushed
the
add-go-changelog
branch
from
a654c4c
to
a721950
Compare
CONTRIBUTING.md
Outdated
| @@ -17,13 +17,14 @@ | |||
| 1. [Updating consul-helm](#updating-consul-helm) | |||
| 1. [Testing a new CRD](#testing-a-new-crd) | |||
| 1. [Update Consul K8s acceptance tests](#update-consul-k8s-acceptance-tests) | |||
| 1. [Adding a new ACL Token](#adding-a-new-acl-token) | |||
| 1. [Testing the Helm chart](#testing-the-helm-chart) | |||
| 3. [Adding a new ACL Token](#adding-a-new-acl-token) | |||
There was a problem hiding this comment.
we should keep these as is. markdown does the right things with the indexing if you keep them all at "1"
- added templates for go-changelog, pretty much copied from Consul - added a checker for missing changelog entries
- Prepare release now requires an additional LAST_RELEASE_GIT_TAG environment variable required by go-changelog - removed adding the unreleased tag to the Changelog as we will no longer be doing that. All changelog entries will be added at the time of release by the go-changelog tool
wilkermichael
force-pushed
the
add-go-changelog
branch
from
848fc44
to
f52927d
Compare
|
I'm merging this in without waiting for the tests to pass, nothing I've done touches production code |
wilkermichael
added a commit
that referenced
this pull request
Feb 28, 2023
* Added some go-changelog automations - added templates for go-changelog, pretty much copied from Consul - added a checker for missing changelog entries * added contributing doc information on new changelog * update prepare release to update the changelog - Prepare release now requires an additional LAST_RELEASE_GIT_TAG environment variable required by go-changelog - removed adding the unreleased tag to the Changelog as we will no longer be doing that. All changelog entries will be added at the time of release by the go-changelog tool
absolutelightning
pushed a commit
that referenced
this pull request
Aug 4, 2023
* Added some go-changelog automations - added templates for go-changelog, pretty much copied from Consul - added a checker for missing changelog entries * added contributing doc information on new changelog * update prepare release to update the changelog - Prepare release now requires an additional LAST_RELEASE_GIT_TAG environment variable required by go-changelog - removed adding the unreleased tag to the Changelog as we will no longer be doing that. All changelog entries will be added at the time of release by the go-changelog tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I always add details to my commits and there isn't any crossover, so reviewing commit by commit is usually the best way to review my PRs
Changes proposed in this PR:
This PR adds go-changelog support to the Consul-K8s repo. This will be a new way of managing changelog items throughout the release cycle.
go-changelogrequired templates and directoriespr/no-changelogfor ignoring missing changelogs if necessary otherwise a changelog is now requiredgo-changelogtoolprepare-releaseto automatically rungo-changelogand add the changes to theCHANGELOG.MDfileHow I've tested this PR:
v1.0.4and it generated a valid changelog:make prepare-releaseand confirmed that it adds the changes with the correct version and date toCHANGELOG.MDHow I expect reviewers to test this PR:
馃憖
Checklist: