Backport of inject envoy_telemetry_bind_socket_dir proxy config when telemetry collector is enabled into release/1.0.x #2211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/telemetry-collector/inject-envoy-config/hugely-climbing-pheasant
branch
from
49d2a29
to
2612676
Compare
|
Closing this off since we are not support 1.0.x |
auto-merge was automatically disabled
June 1, 2023 16:02
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #2143 to be assessed for backporting due to the inclusion of the label backport/1.0.x.
The below text is copied from the body of the original PR.
Changes proposed in this PR:
global.metrics.enableTelemetryCollectorvalue to gate logic in the endpoints controller that adds a proxy config option that controls forwarding of envoy telemetry to the consul telemetry collectorHow I've tested this PR:
Checklist:
Overview of commits