Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new load-balancer-address command #234

Merged
merged 1 commit into from
Mar 23, 2020

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Mar 17, 2020

Command usage:

  consul-k8s load-balancer-address \
    -k8s-namespace default \
    -name my-service-name \
    -output-file address.txt

The command will run in a retry loop until the service has been assigned
an ingress IP or hostname. It will then write that address to file.

The command will be used in the helm chart in the init container for the mesh-gateway.

@lkysow lkysow added area/multi-dc Related to running with multiple datacenters type/enhancement New feature or request labels Mar 17, 2020
@lkysow lkysow requested a review from a team March 17, 2020 21:27
@lkysow lkysow marked this pull request as ready for review March 17, 2020 21:27
@lkysow
Copy link
Member Author

lkysow commented Mar 18, 2020

Corresponding helm pr: hashicorp/consul-helm#388

Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Luke. I left a couple of comments inline. Haven't tried it out, but the code changes look good to me.

subcommand/load-balancer-address/command.go Show resolved Hide resolved
subcommand/load-balancer-address/command_test.go Outdated Show resolved Hide resolved
subcommand/load-balancer-address/command_test.go Outdated Show resolved Hide resolved
subcommand/load-balancer-address/command_test.go Outdated Show resolved Hide resolved
@lkysow
Copy link
Member Author

lkysow commented Mar 19, 2020

Thanks! I'll leave the PR open until we've got a chance to test running the command through Helm.

Command usage:
  consul-k8s load-balancer-address \
    -k8s-namespace default \
    -name my-service-name \
    -output-file address.txt

The command will run in a retry loop until the service has been assigned
an ingress IP or hostname. It will then write that address to file.
@lkysow lkysow merged commit 7ba984e into wan-federation-base Mar 23, 2020
@lkysow lkysow deleted the load-balancer-address branch March 23, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/multi-dc Related to running with multiple datacenters type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants