Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load-balancer-address support for ClusterIP #235

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Mar 23, 2020

  • Support retrieving ClusterIP services with the load-balancer-address
    command.
  • Rename load-balancer-addresss to service-address since it no longer
    applies to just load balancer services.

@lkysow lkysow marked this pull request as ready for review March 23, 2020 22:42
@lkysow lkysow requested a review from a team March 23, 2020 22:42
@lkysow lkysow added area/multi-dc Related to running with multiple datacenters type/enhancement New feature or request labels Mar 23, 2020
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I've just added a couple of minor comments.

subcommand/service-address/command.go Outdated Show resolved Hide resolved
subcommand/service-address/command.go Outdated Show resolved Hide resolved
subcommand/service-address/command.go Outdated Show resolved Hide resolved
subcommand/service-address/command.go Outdated Show resolved Hide resolved
- Support retrieving ClusterIP services with the load-balancer-address
command.
- Rename load-balancer-addresss to service-address since it no longer
applies to just load balancer services.
@lkysow lkysow merged commit 06abc9f into wan-federation-base Mar 26, 2020
@lkysow lkysow deleted the service-address branch March 26, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/multi-dc Related to running with multiple datacenters type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants