Update resources for lifecycle sidecar and init container for connect-inject #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschoche
added
type/bug
lkysow
approved these changes
Jul 9, 2020
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
ndhanushkodi
pushed a commit
to ndhanushkodi/consul-k8s
that referenced
this pull request
Jul 9, 2021
Bump default consul version to 1.6.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the initContainer for connect-inject has a resource limit of 25Mi, this was introduced as a feature in the 0.16.0 release.
As part of it's runtime the initContainer issues a cp of the consul binary (100Mi+). Normally this is fine but it is possible to get into a situation where the host is under resource pressure and enough dirty pages from the cp operation accumulate in memory such that an OOM is triggered.
The initContainer is short lived and we just need it to run, so increase the resource limit to the size of the consul binary.
Likewise the lifecycle sidecar's settings were set too low, we double the cpu resources to alleviate cpu constraints.
This resolves #283