Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lifecycle sidecar memory limit flag default value #300

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Update lifecycle sidecar memory limit flag default value #300

merged 1 commit into from
Jul 28, 2020

Conversation

adilyse
Copy link
Contributor

@adilyse adilyse commented Jul 28, 2020

Changes proposed in this PR:

  • Update lifecycle sidecar memory limit flag default value to 50Mi

How I've tested this PR:
Updated default value test.

How I expect reviewers to test this PR:
Verify the test functions as expected, includes the updated value and passes.

Checklist:

  • [ x ] Tests added
  • [ N/A ] CHANGELOG entry added (HashiCorp engineers only, community PRs should not add a changelog entry)

@adilyse adilyse added the area/connect Related to Connect service mesh, e.g. injection label Jul 28, 2020
@adilyse adilyse requested review from a team, lkysow and kschoche and removed request for a team July 28, 2020 18:34
kschoche
kschoche approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Looks great, thanks!

lkysow
lkysow approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this does need a changelog entry that the default has changed to 50Mi.

@adilyse adilyse merged commit 8c68342 into master Jul 28, 2020
@adilyse adilyse deleted the update-default branch July 28, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkysow lkysow lkysow approved these changes

@kschoche kschoche kschoche approved these changes

Assignees
No one assigned
Labels
area/connect Related to Connect service mesh, e.g. injection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adilyse @lkysow @kschoche