Health Checks support for consul service mesh #363
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
Unit tests have been added which cover permutations of Upsert/Reconcile states, acceptance tests are pending in the associated consul-helm PR which covers end-to-end.
Manual tests are also possible when using consul-helm/hc-base to deploy with
connectInject.healthChecks.enabled=true
How I expect reviewers to test this PR:
Check out the code and run the unit tests
Checklist: