Add -log-level flag to inject-connect, healthchecks debug logs #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
force-pushed
the
log-levels
branch
2 times, most recently
from
8eb103d
to
14f0384
Compare
lkysow
commented
Nov 20, 2020
| Level: hclog.Info, | ||
| Output: os.Stderr, | ||
| }) | ||
| logger := hclog.Default() |
There was a problem hiding this comment.
Should we use the constructor here?
There was a problem hiding this comment.
You mean swap it back to hclog.New() or use `common.Logger("info")?
There was a problem hiding this comment.
use common.Logger(hclog.Info) for consistency?
There was a problem hiding this comment.
Not a huge deal for me one way or the other btw.
There was a problem hiding this comment.
Good idea because we might add more to that function and expect it to apply to all loggers.
lkysow
commented
Nov 20, 2020
lkysow
requested review from
kschoche,
a team and
ishustava
and removed request for
a team
ishustava
approved these changes
Nov 20, 2020
| Level: hclog.Info, | ||
| Output: os.Stderr, | ||
| }) | ||
| logger := hclog.Default() |
There was a problem hiding this comment.
Should we use the constructor here?
Also standardize on how we construct logger throughout commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
-log-levelflag toinject-connectso we can configure the health check log levelcommonso it can be reusedHow I've tested this PR:
How I expect reviewers to test this PR:
Checklist: