Make -consul-image and -envoy-image required #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
force-pushed
the
require-flags
branch
from
22af789
to
42d1dce
Compare
lkysow
requested review from
a team,
ishustava and
thisisnotashwin
and removed request for
a team
ishustava
approved these changes
Nov 26, 2020
subcommand/inject-connect/command.go
Outdated
| @@ -106,10 +106,10 @@ func (c *Command) init() { | |||
| "PEM-encoded TLS certificate to serve. If blank, will generate random cert.") | |||
| c.flagSet.StringVar(&c.flagKeyFile, "tls-key-file", "", | |||
| "PEM-encoded TLS private key to serve. If blank, will generate random cert.") | |||
| c.flagSet.StringVar(&c.flagConsulImage, "consul-image", connectinject.DefaultConsulImage, | |||
| c.flagSet.StringVar(&c.flagConsulImage, "consul-image", "", | |||
| "Docker image for Consul. Defaults to consul:1.7.1.") | |||
There was a problem hiding this comment.
Suggested change
| "Docker image for Consul. Defaults to consul:1.7.1.") | |
| "Docker image for Consul.") |
thisisnotashwin
approved these changes
Nov 30, 2020
These flags have been set in Helm for at least 9 months. If they aren't set then our default versions were too old and wouldn't work. Making them required means we won't need to update them here in addition to in consul-helm.
ndhanushkodi
pushed a commit
to ndhanushkodi/consul-k8s
that referenced
this pull request
Jul 9, 2021
When auto-encrypt is enabled we need to use the volume with the client's CA rather than the server's.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These flags have been set in Helm for at least 9 months. If they aren't
set then our default versions were too old and wouldn't work. Making
them required means we won't need to update them here in addition to in
consul-helm.
How I've tested this PR:
I haven't but you can see the flags set here: https://github.com/hashicorp/consul-helm/blob/master/templates/connect-inject-deployment.yaml#L85-L86
How I expect reviewers to test this PR:
Code
Checklist: