[NET-9500] Cleanup orphaned inline-certs and acl role/policy (#4067) #4132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add cleanup goroutine to handle cleaning up old acl roles and inline certs * added first unit test * added more tests * fixing binding rule deleting * linting * added tests and cleaned up * Update control-plane/api-gateway/binding/cleanup.go Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com> * Update control-plane/api-gateway/binding/cleanup.go Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com> * Update control-plane/api-gateway/binding/cleanup.go Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com> * Update control-plane/api-gateway/binding/cleanup_test.go Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com> * Increase sleep time --------- Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>
jm96441n
added
pr/no-changelog
wangxinyi7
approved these changes
Jun 13, 2024
nathancoleman
approved these changes
Jun 13, 2024
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manual backport
Changes proposed in this PR
How I've tested this PR
How I expect reviewers to test this PR
Checklist