Update health check status based on the endpoints object instead of pod #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishustava
added
type/bug
ishustava
force-pushed
the
fix-health-check-status-bug
branch
2 times, most recently
from
5fbdcc2
to
e928fbd
Compare
lkysow
reviewed
Apr 23, 2021
ishustava
requested review from
a team,
lkysow and
ndhanushkodi
and removed request for
a team
Previously, we were updating health check status based on the pod status of the pod that the endpoints address is pointing to. However, since the endpoints controller is not watching pod objects, it will not always have the most updated pod information in the cache. This results in incorrect behavior where sometimes the pod we get will have stale information and we update the health check status in Consul incorrectly. This commit changes this behavior to instead get the health check status from the endpoints object. The endpoints object already has information about ready and not ready addresses, and it will always have updated cache since we receive events based on updates from the Kubernetes API server to the cached Informer.
ishustava
force-pushed
the
fix-health-check-status-bug
branch
from
e928fbd
to
9ddfbfb
Compare
ishustava
force-pushed
the
fix-health-check-status-bug
branch
from
eb609b9
to
be3f922
Compare
ndhanushkodi
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were updating health check status based on the pod status
of the pod that the endpoints address is pointing to. However, since the
endpoints controller is not watching pod objects, it will not always have
the most updated pod information in the cache. This results in incorrect behavior
where sometimes the pod we get will have stale information and we update the
health check status in Consul incorrectly.
This PR changes this behavior to instead get the health check status from
the endpoints object. The endpoints object already has information about ready
and not ready addresses, and it will always have updated cache since we receive
events based on updates from the Kubernetes API server to the cached Informer.
How I've tested this PR:
Acceptance test here
How I expect reviewers to test this PR:
code review
Checklist: