Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mode to ProxyDefault configEntry #505

Merged
merged 3 commits into from
Apr 28, 2021
Merged

Conversation

thisisnotashwin
Copy link
Contributor

Changes proposed in this PR:

  • Update ProxyDefaults with the field mode.

How I've tested this PR: Acceptance tests

How I expect reviewers to test this PR: Code review

Checklist:

  • Tests added
  • CHANGELOG entry added (HashiCorp engineers only, community PRs should not add a changelog entry)

Copy link
Contributor

@ndhanushkodi ndhanushkodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Ashwin! Just a nit suggestion.

api/v1alpha1/proxydefaults_types.go Outdated Show resolved Hide resolved
api/v1alpha1/proxydefaults_types.go Outdated Show resolved Hide resolved
config/crd/bases/consul.hashicorp.com_proxydefaults.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@thisisnotashwin thisisnotashwin force-pushed the update-service-defaults branch 3 times, most recently from 9747805 to 8daac6a Compare April 27, 2021 20:21
Base automatically changed from update-service-defaults to master April 28, 2021 13:31
kschoche and others added 3 commits April 28, 2021 09:31
…th checks (#472)

remove health checks controller and use endpoints controller for health checks.
- Update the spec of ServiceDefaults and ProxyDefaults to support
  transparent proxy changes that are introduced as a part of Consul 1.10
@thisisnotashwin thisisnotashwin merged commit 39de466 into master Apr 28, 2021
@thisisnotashwin thisisnotashwin deleted the update-proxy-defaults branch April 28, 2021 13:33
ndhanushkodi pushed a commit to ndhanushkodi/consul-k8s that referenced this pull request Jul 9, 2021
* Client templates to use rolebindings instead of clusterrolebindings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants