Don't set security context when on OpenShift #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishustava
requested review from
a team,
ndhanushkodi,
thisisnotashwin and
lkysow
and removed request for
a team and
thisisnotashwin
* Envoy container should not have security context set when on OpenShift and when tproxy is disabled because we want to let OpenShift set a random user/group. When tproxy is enabled though, we need to still set it on OpenShift because we require Envoy to have a specific user for the traffic redirection to work. * init-copy-container doesn't need to have security context set whenever running on OpenShift (regardless of whether tproxy is enabled or not) so that OpenShift can set its own random user/group.
ishustava
force-pushed
the
tproxy-openshift
branch
from
30280eb
to
6f5742e
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and when tproxy is disabled because we want to let OpenShift set a random
user/group. When tproxy is enabled though, we need to still set it on OpenShift
because we require Envoy to have a specific user for the traffic redirection to work.
(regardless of whether tproxy is enabled or not) so that OpenShift can set its own random user/group.
How I've tested this PR:
acceptance tests on openshift
How I expect reviewers to test this PR:
code review
Checklist: