Update v1beta1 to v1 for webhook cert manager #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnotashwin
approved these changes
Jul 9, 2021
|
🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you are running Kubernetes 1.19+ you will have the following logs flooding the the cert manager webhook:
Changes proposed in this PR:
clientset.AdmissionregistrationV1instead ofclientset.AdmissionregistrationV1beta1API as it was deprecated in k8s 1.16.How I've tested this PR:
manually deployed to k8s 1.20 and confirmed the warnings are gone
Unit tests updated and still pass.
How I expect reviewers to test this PR:
code review
Checklist: