Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify port for ui service #604

Merged
merged 3 commits into from
Aug 13, 2021
Merged

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Aug 12, 2021

I followed the same pattern as for nodePort. This is generally useful for specifying load balancer ports and we have this option already for mesh gateways. This is also useful for running in Minikube because minikube tunnel will open up localhost:<port> and so you can have the Consul UI on localhost:8500 rather than localhost:80.

Taken from hashicorp/consul-helm#1062

How I've tested this PR:

  • helm tests

How I expect reviewers to test this PR: code

Checklist:

  • Bats tests added
  • CHANGELOG entry added (HashiCorp engineers only, community PRs should not add a changelog entry)

@lkysow
Copy link
Member Author

lkysow commented Aug 12, 2021

From @kschoche

Looks great! Given that you mentioned it's potentially helpful in minikube, could we update a doc as well somewhere pointing this out? No worries if not.

Our minikube guide uses minikube service consul-ui (https://learn.hashicorp.com/tutorials/consul/kubernetes-minikube?utm_source=consul.io&utm_medium=docs&utm_content=k8s&utm_term=mk#access-the-consul-ui) which is another way to do it so I don't think we need to update that guide.

minikube tunnel is nice if you hav multiple services but that's a unique use-case.

Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@sadjamz sadjamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll be really useful (I think for the CLI too?) thanks Luke!

@lkysow lkysow merged commit 98b0c71 into master Aug 13, 2021
@lkysow lkysow deleted the lkysow/port-customize branch August 13, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants