Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow registering the same service in multiple namespaces. #697

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Allow registering the same service in multiple namespaces. #697

merged 2 commits into from
Sep 1, 2021

Conversation

NicoletaPopoviciu
Copy link
Collaborator

@NicoletaPopoviciu NicoletaPopoviciu commented Aug 30, 2021 •
edited
Loading

Changes proposed in this PR:

  • Allow registering the same service in multiple namespaces.

How I've tested this PR:

  • Ran the endpoints controller test suite locally.

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added (HashiCorp engineers only, community PRs should not add a changelog entry)

@NicoletaPopoviciu NicoletaPopoviciu requested review from a team, ishustava and thisisnotashwin and removed request for a team August 30, 2021 21:08
thisisnotashwin
thisisnotashwin approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 Can we add a CHANGELOG entry for this change? As an aside, are there any docs updates that are required as a part of this change?

@NicoletaPopoviciu
Copy link
Collaborator Author

@thisisnotashwin I checked w @ishustava and we did not not have any docs changes. Thank you for the reminder !

@NicoletaPopoviciu NicoletaPopoviciu merged commit edb1286 into main Sep 1, 2021
@NicoletaPopoviciu NicoletaPopoviciu deleted the nicoleta-allow-duplicate-services branch September 1, 2021 16:07
@ndhanushkodi ndhanushkodi mentioned this pull request Sep 1, 2021
Closed
lawliet89 pushed a commit to lawliet89/consul-k8s that referenced this pull request Sep 13, 2021
@ishustava
Fix link to health checks docs in Changelog (hashicorp#697)
1e93332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishustava ishustava ishustava approved these changes

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NicoletaPopoviciu @ishustava @thisisnotashwin