add resource config for ServiceInit #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yq selector was incorrect
|
Hi @mark-vw thanks for the PR! Could you let us know when you think this PR is ready for review? |
|
Hi David! Thanks for following up. I plan to submit the PR sometime tomorrow.
…-------- Original message --------
From: David Yu ***@***.***>
Date: 10/4/21 5:16 PM (GMT-08:00)
To: hashicorp/consul-k8s ***@***.***>
Cc: Mark ***@***.***>, Mention ***@***.***>
Subject: Re: [hashicorp/consul-k8s] add resource config for ServiceInit (#758)
Hi @mark-vw<https://github.com/mark-vw> thanks for the PR! Could you let us know when you think this PR is ready for review?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#758 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALGWRY2UZMQEH3DFGHVSFRLUFI7VTANCNFSM5FJ3N2AA>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Update default values to the original values defined in mesh-gateway-deployment.yaml
|
@david-yu, this is now ready for review. |
lkysow
reviewed
Oct 5, 2021
No need for string-based config support as this is a new setting
lkysow
added a commit
that referenced
this pull request
Oct 5, 2021
lkysow
added a commit
that referenced
this pull request
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: