-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Gossip Autogenerate Command #789
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Thomas, this looks good!
Just one minor comment, but I'm approving assuming this will be fixed before merging.
charts/consul/templates/gossip-encryption-autogenerate-job.yaml
Outdated
Show resolved
Hide resolved
I'm having trouble debugging the failing acceptance test. Putting a sticky note here that I'll need a buddy to help me get unblocked. |
Never mind, just an intermittent issue. |
charts/consul/templates/gossip-encryption-autogenerate-job.yaml
Outdated
Show resolved
Hide resolved
90945f6
to
3588a06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!!
Changes proposed in this PR:
get
perm to gossip autogenerate roleimageK8S
and run command from jobHow I've tested this PR:
I pushed an image of the control plane on the
main
branch totecke/consul-k8s-dev
. You can test running the autogeneration flag with the following Helm values:How I expect reviewers to test this PR:
Reviewers can test the PR using the same settings listed above. They may also wish to check that
bats
tests pass.Reviewers, do you see any need for additional
bats
tests as a result of this change?Checklist: