Support Cross Partition Networking #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisisnotashwin
requested review from
ndhanushkodi,
a team and
kschoche
and removed request for
a team
thisisnotashwin
changed the title
thisisnotashwin
force-pushed
the
partition-mesh-gws
branch
from
4cef03f
to
9287e43
Compare
kschoche
reviewed
Oct 28, 2021
kschoche
reviewed
Oct 28, 2021
kschoche
reviewed
Oct 28, 2021
thisisnotashwin
force-pushed
the
partition-mesh-gws
branch
4 times, most recently
from
f07bc30
to
9e5cee7
Compare
thisisnotashwin
force-pushed
the
partition-mesh-gws
branch
2 times, most recently
from
9bcba1f
to
2ee9dc8
Compare
ndhanushkodi
approved these changes
Oct 29, 2021
thisisnotashwin
force-pushed
the
partition-mesh-gws
branch
from
efaa483
to
c972097
Compare
- This PR does not include acceptance tests. The desired acceptance tests will be determined based on the expected behavior of ServiceExports when partitions are disabled. - Similarly, controller tests have not been added as our existing controller tests only account for namespace. The behavior with partitions has not been resolved.
thisisnotashwin
force-pushed
the
partition-mesh-gws
branch
from
c972097
to
6c5cc48
Compare
kschoche
approved these changes
Oct 29, 2021
ottaviohartman
pushed a commit
to ottaviohartman/consul-k8s
that referenced
this pull request
Nov 3, 2021
* Drop support for Helm 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: