Use component label everywhere #840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a test to ensure every file has it.
lkysow
force-pushed
the
lkysow/component-labels
branch
from
f25e4a6
to
2e68b75
Compare
lkysow
requested review from
a team,
ishustava and
sadjamz
and removed request for
a team
ishustava
approved these changes
Nov 4, 2021
| @@ -9,7 +9,7 @@ metadata: | |||
| chart: {{ template "consul.chart" . }} | |||
| heritage: {{ .Release.Service }} | |||
| release: {{ .Release.Name }} | |||
| component: controller | |||
| component: connect-injector | |||
charts/consul/templates/gossip-encryption-autogenerate-job.yaml
Outdated
Show resolved
Hide resolved
| cd `chart_dir` | ||
| # Grep for files that don't have 'component: ' in them | ||
| local actual=$(grep -L 'component: ' templates/*.yaml | tee /dev/stderr ) | ||
| [ "${actual}" = '' ] |
There was a problem hiding this comment.
nice! that good ol' grep test 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a test to ensure every file has it.
Fixes #673
Checklist: