Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precheck to verify the correct license secret exists when using an ent image. #875

Merged
merged 16 commits into from
Nov 30, 2021
Merged

Precheck to verify the correct license secret exists when using an ent image. #875

merged 16 commits into from
Nov 30, 2021

Conversation

NicoletaPopoviciu
Copy link
Collaborator

@NicoletaPopoviciu NicoletaPopoviciu commented Nov 23, 2021 •
edited
Loading

Changes proposed in this PR:

  • Added precheck in the install command where we verify the correct license secret exists when using an ent image

How I've tested this PR:

  • ran tests locally
  • ran ./consul-k8s install -f nicoleta.yaml with different values in the yaml file

How I expect reviewers to test this PR:
👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

ishustava
ishustava reviewed Nov 24, 2021
View reviewed changes
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good, Nicoleta! I left some comments inline.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
cli/cmd/install/install.go Outdated Show resolved Hide resolved
cli/cmd/install/install.go Show resolved Hide resolved
cli/cmd/install/install.go Outdated Show resolved Hide resolved
cli/cmd/install/install.go Outdated Show resolved Hide resolved
ndhanushkodi
ndhanushkodi approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@ndhanushkodi ndhanushkodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about a test, but otherwise I have nothing blocking the merge other than what Iryna mentioned!

cli/cmd/install/install.go Outdated Show resolved Hide resolved
cli/cmd/install/install_test.go Outdated Show resolved Hide resolved
NicoletaPopoviciu and others added 7 commits November 24, 2021 16:42
@NicoletaPopoviciu @ishustava
Update CHANGELOG.md
dace091 
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
@NicoletaPopoviciu @ishustava
Update CHANGELOG.md
5743252 
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
@NicoletaPopoviciu @ishustava
Update cli/cmd/install/install.go
12d438c 
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
@NicoletaPopoviciu @ishustava
Update cli/cmd/install/install.go
5e8584f 
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
@NicoletaPopoviciu @ishustava
Update cli/cmd/install/install.go
b519b78 
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
@NicoletaPopoviciu @ndhanushkodi
Update cli/cmd/install/install_test.go
56d4413 
Co-authored-by: Nitya Dhanushkodi <nitya@hashicorp.com>
@NicoletaPopoviciu
address PR comments
6539112
@NicoletaPopoviciu NicoletaPopoviciu merged commit 98585af into main Nov 30, 2021
@NicoletaPopoviciu NicoletaPopoviciu deleted the nicoleta-ent-secret-check branch November 30, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndhanushkodi ndhanushkodi ndhanushkodi approved these changes

@ishustava ishustava ishustava approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NicoletaPopoviciu @ndhanushkodi @ishustava