Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.11 #935

Merged
merged 1 commit into from
Dec 15, 2021
Merged

1.11 #935

merged 1 commit into from
Dec 15, 2021

Conversation

thisisnotashwin
Copy link
Contributor

@thisisnotashwin thisisnotashwin commented Dec 15, 2021 •
edited
Loading

Changes proposed in this PR:

  • Support Consul 1.11.0

How I've tested this PR:

  • pipelines

How I expect reviewers to test this PR:

  • 👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@thisisnotashwin thisisnotashwin requested review from a team, ndhanushkodi and t-eckert and removed request for a team December 15, 2021 03:34
@thisisnotashwin thisisnotashwin force-pushed the prep-for-1.11 branch 2 times, most recently from 1a88ebd to edfd7fe Compare December 15, 2021 03:42
david-yu
david-yu reviewed Dec 15, 2021
View reviewed changes
charts/consul/Chart.yaml Outdated Show resolved Hide resolved
david-yu
david-yu reviewed Dec 15, 2021
View reviewed changes
charts/consul/Chart.yaml Outdated Show resolved Hide resolved
david-yu
david-yu reviewed Dec 15, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@thisisnotashwin
Copy link
Contributor Author

thanks @david-yu

t-eckert
t-eckert approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@t-eckert t-eckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisisnotashwin thisisnotashwin merged commit 1c07e5b into main Dec 15, 2021
@thisisnotashwin thisisnotashwin deleted the prep-for-1.11 branch December 15, 2021 22:12
@david-yu david-yu mentioned this pull request Jan 18, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-yu david-yu david-yu approved these changes

@ndhanushkodi ndhanushkodi ndhanushkodi approved these changes

@t-eckert t-eckert t-eckert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thisisnotashwin @david-yu @ndhanushkodi @t-eckert