-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support commas in tag annotation. #983
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean! I like it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!!
Commas can be set by escaping with backslash. Example: annotation: "this,supports,commas\,now" Becomes: ["this", "supports", "commas,now"]
Co-authored-by: Nitya Dhanushkodi <nitya@hashicorp.com>
7924fd5
to
45eb49a
Compare
* Update test/unit/server-acl-init-job.bats Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>
@lkysow Thanks for fixing!!
When I use curl to get the service tags, http://127.0.0.1:8500/v1/catalog/services
You can see the tag is incorrectly parsed. I suspect it may be related to the double slash \, wondering if that is a known bug/issue, can I resolve it by upgrading the version or is there some clever workaround? Thanks for the helping, this is current the blocker for our team to onboard using Consul :) |
Commas can be set by escaping with backslash. Fixes #719
Example:
Becomes:
How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: