Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure vault integration works with PSPs #985

Merged
merged 3 commits into from
Jan 21, 2022
Merged

Make sure vault integration works with PSPs #985

merged 3 commits into from
Jan 21, 2022

Conversation

ishustava
Copy link
Contributor

@ishustava ishustava commented Jan 20, 2022

Changes proposed in this PR:

  • Update server-acl-init PSP to have access to mount emptyDir volumes for the vault injector
  • Scale up gke cluster so accommodate for everything we're installing in the vault test

How I've tested this PR:
acceptance tests: https://app.circleci.com/pipelines/github/hashicorp/consul-k8s/4015/workflows/87c78757-4c96-4641-a2f0-d535bbe567fc/jobs/36509

How I expect reviewers to test this PR:
👀

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@ishustava ishustava marked this pull request as ready for review January 20, 2022 22:39
@ishustava ishustava requested review from a team, kschoche and thisisnotashwin and removed request for a team January 20, 2022 22:40
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪄 This is a very very good find! Devil in the details and all that.

@@ -18,6 +18,7 @@ spec:
# Allow core volume types.
volumes:
- 'secret'
- 'emptyDir'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GENIUS! pure unadulterated genius.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -10,6 +10,7 @@ IMPROVEMENTS:
* Allow customization of `terminationGracePeriodSeconds` on the ingress gateways. [[GH-947](https://github.com/hashicorp/consul-k8s/pull/947)]
* Support `ui.dashboardURLTemplates.service` value for setting [dashboard URL templates](https://www.consul.io/docs/agent/options#ui_config_dashboard_url_templates_service). [[GH-937](https://github.com/hashicorp/consul-k8s/pull/937)]
* Allow using dash-separated names for config entries when using `kubectl`. [[GH-965](https://github.com/hashicorp/consul-k8s/pull/965)]
* Support Pod Security Policies with Vault integration. [[GH-985](https://github.com/hashicorp/consul-k8s/pull/985)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

Copy link
Contributor

@kschoche kschoche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo thanks!

@ishustava ishustava merged commit 7e4855d into main Jan 21, 2022
@ishustava ishustava deleted the vault-psp-test branch January 21, 2022 17:13
@jmurret jmurret added the vault label Mar 24, 2022
geobeau pushed a commit to geobeau/consul-k8s that referenced this pull request May 20, 2022
* Add support for recursor flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants