Standardize resource names across the helm chart #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkysow
reviewed
Jan 25, 2022
thisisnotashwin
force-pushed
the
standardize-resource-names
branch
4 times, most recently
from
55d9ab1
to
cc59742
Compare
thisisnotashwin
requested review from
lkysow,
a team and
t-eckert
and removed request for
a team
2 tasks
thisisnotashwin
force-pushed
the
standardize-resource-names
branch
from
b38f4e0
to
7842c75
Compare
lkysow
reviewed
Jan 26, 2022
| @@ -3,7 +3,7 @@ | |||
| apiVersion: rbac.authorization.k8s.io/v1 | |||
| kind: ClusterRole | |||
| metadata: | |||
| name: {{ template "consul.fullname" . }}-connect-injector-authmethod-role | |||
| name: {{ template "consul.fullname" . }}-connect-injector-authmethod | |||
There was a problem hiding this comment.
I think these can all be -connect-injector
| @@ -3,7 +3,7 @@ | |||
| apiVersion: rbac.authorization.k8s.io/v1 | |||
| kind: ClusterRoleBinding | |||
| metadata: | |||
| name: {{ template "consul.fullname" . }}-connect-injector-authmethod-authdelegator-role-binding | |||
| name: {{ template "consul.fullname" . }}-connect-injector-authmethod-authdelegator | |||
There was a problem hiding this comment.
this can be -connect-injector-authdelegator since this is a special clusterrolebinding where we're binding to a preset role vs how we're usually binding to a role we've created. So this can be with the special name and the rest can be just the name of the component, i.e. -connect-injector
| namespace: {{ .Release.Namespace }} | ||
| --- | ||
| apiVersion: rbac.authorization.k8s.io/v1 | ||
| kind: ClusterRoleBinding | ||
| metadata: | ||
| name: {{ template "consul.fullname" . }}-connect-injector-authmethod-serviceaccount-role-binding | ||
| name: {{ template "consul.fullname" . }}-connect-injector-authmethod-serviceaccount |
There was a problem hiding this comment.
and then this can just be -connect-injector
lkysow
reviewed
Jan 26, 2022
lkysow
approved these changes
Jan 26, 2022
thisisnotashwin
force-pushed
the
standardize-resource-names
branch
from
e69ef33
to
c80c9ec
Compare
t-eckert
approved these changes
Jan 26, 2022
geobeau
pushed a commit
to geobeau/consul-k8s
that referenced
this pull request
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
server-acl-initas the secret name was hard-coded to use the-svc-aaccountsuffix.How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: