New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to gomod #1208
Migrate to gomod #1208
Conversation
`go mod init` is all that was executed
Drop `dep` support
cb28f71
to
2c9d320
Compare
Last time this worked was e7889f2 - Aug 26, 2017
2148214
to
3b5c461
Compare
3b5c461
to
37b8a94
Compare
They're supposed to be env vars for any builds, not to produce multiple builds.
Ready for review. Test suite passes and overall looks good to me. |
It looks good. Although I'd keep the edit the vault, vault/api, vault/sdk split creates some trouble. The tests should not import |
I presume the plan is to modify the circle CI configuration to run vault as a service? At the same time might it also be worth moving to doing the same with consul given that As an aside depending directly on vault is made particularly fun at the moment by the fact vault currently depends on its API but at a different version to itself, so you end up with an ambiguous import (see here). Edit: |
I didn't use docker, as I don't like requiring it for basic tests as it's generally easier to wrap things in docker at a higher level if you don't integrate docker into things. Otherwise see #1230 for details on how I implemented it. |
@syndbg Thanks for doing this and even though I ended up doing this myself having your version around was handy for checking some things. |
Goals:
consul-template
to go modules. This fixes troubles for anyone attempting to use this project as a library.Makefile
to support above go modules change.Makefile
anddep
..travis.yml
to aMakefile
target. This eases everyone's project setup. Now to run the tests all I do issudo make download-consul
followed bymake test
. No need to download Consul manually by following a link. Also, I make sure that I test using the same Consul used in CI. Docs are also updated to reflect this.Did I miss something?
Imo this is a huge milestone that would modernize the project a bit, since it's pretty stale by nowadays.