once-wait-conflict #1227
Merged
once-wait-conflict #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait timers disabled so that it blocks on all dependencies, completing the template execution only once it has all the data. Keeps it from returning before all dependencies have returned. Note it is treating the logic here at configuration time, so it disables any configured Wait settings if it gets -once. Include documentation updates and tests. Refactors use of `once` variables to make them part of the config setup. Fixes #1196, fixes #1207, fixes #1209
When configs don't match output a simple diff of the 2 configs instead of just dumping both of them. Much easier to read to find errors. Also added nil guards on config Copy/Finalize to get parity with Merge and to eliminate need for checks in tests.
freddygv
approved these changes
Jul 8, 2019
There was a problem hiding this comment.
This looks good to me @eikenb.
My only suggestion is that It would help if the PR name had a description rather than the issue number. It's a little easier to get to the issue if it's linked to from the PR comment as was done here:
hashicorp/envconsul#208
|
Thanks @freddygv! I updated the PR name to be more descriptive as suggested and added the related issues to the description (didn't use the Fixes syntax as that's already in a commit). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix -once to ignore wait/quiescence timers
addresses issues: #1196, #1207, #1209