Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vault retry logic on failed calls #1269

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Commits on Aug 30, 2019

  1. fix vault retry logic on failed calls

    The original problem was that for non-renewable vault secrets that it
    was having trouble fetching, it would wait the standard exponential
    backoff time plus the configured sleep time (like it does between
    successful fetches). When what it should do is use the sleep time
    between successful fetches and exponential backoff on failures.
    
    While fixing this I cleaned up the code to make the logic clear.
    The issue existed in both vault_read and vault_write, and they shared a
    common chunk of renew logic between them and with vault_token. So I
    refactored that out into a common function.
    
    Fixes #1224
    eikenb committed Aug 30, 2019
    Configuration menu
    Copy the full SHA
    14f8395 View commit details
    Browse the repository at this point in the history