Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1441 blockquerywait #1443

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Issue 1441 blockquerywait #1443

merged 3 commits into from
Jan 19, 2021

Commits on Jan 16, 2021

  1. add test for block_query_wait setting not taking

    @eikenb
    eikenb committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    3f8d36d View commit details
    Browse the repository at this point in the history

  2. fix issue with block_query_wait setting 

    The block_query_wait field is a pointer type on the struct. Nil typed
fields always need to be checked vs. nil in Merge() functions. I think
this was missed as it was put below Once which is of type bool and
doesn't need it (ie. followed bad pattern).
    @eikenb
    eikenb committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    665dacb View commit details
    Browse the repository at this point in the history

  3. test cleanup 

    Don't use default value in tests that compare values.

When outputing test diffs, try harder to output values instead of
pointers ints.

Fix formatting of config's GoString() output.
    @eikenb
    eikenb committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    8ab9628 View commit details
    Browse the repository at this point in the history