Various code quality fixes/linting #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1398,7 +1398,7 @@ func NewClientSet(c *config.Config) (*dep.ClientSet, error) { | |||
| } | |||
|
|
|||
| // newWatcher creates a new watcher. | |||
| func newWatcher(c *config.Config, clients *dep.ClientSet, once bool) *watch.Watcher { | |||
There was a problem hiding this comment.
good catch 👍🏾
| @@ -146,12 +146,6 @@ func sha1Map(m map[string]interface{}) string { | |||
| return fmt.Sprintf("%.4x", h.Sum(nil)) | |||
| } | |||
|
|
|||
| func (d *VaultWriteQuery) printWarnings(warnings []string) { | |||
There was a problem hiding this comment.
this isn't used but i wonder why it was added in the first place
roncodingenthusiast
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fixes, including:
FileModein tests and in octal format to matchos.FilemodeClientUserAgentfield forVaultConfigprintWarnings()method fromVaultWriteQueryonceparameter fromnewWatcher()as it's reachable throughconfigparameter as wellFigured it would make sense to put it all into a single PR rather than multiple (almost) one-line changes :)