Create ServerErrCh to surface server errors back to caller. #1897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyaac
force-pushed
the
VAULT-23741_Surface_Server_Error_To_Vault_Agent
branch
2 times, most recently
from
f881db1
to
78343c7
Compare
Create a channel to surface error from server Created a channel to surface server errors Create a channel to surface error from server Dummy commit Edited linters Edited runner initialization
divyaac
force-pushed
the
VAULT-23741_Surface_Server_Error_To_Vault_Agent
branch
from
78343c7
to
70ede88
Compare
VioletHynes
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Looks good! I have some minor comments, but none are blocking.
A test would be great, but I think it would be difficult to test this in consul-template directly and we should be able to have plenty of Agent tests around this, so I don't see that as blocking either!
Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a channel, ServerErrCh that will surface server errors back to the caller. This channel will hold a maximum of one error at a time.
The purpose of this, is to allow Vault Agent and Vault Proxy to re-authenticate if the error message from the server indicates that the token is an "invalid token". More information on this initiative here: https://hermes.hashicorp.services/document/1yTtWJEvyoYLPkYRQ3lxs6dHmqAVyC177BMEBEXuu8fE?draft=false