Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CC-6624: Update FilterBar results text on search #74

Merged
merged 4 commits into from
Oct 5, 2023
Merged

CC-6624: Update FilterBar results text on search #74

merged 4 commits into from
Oct 5, 2023

Conversation

ellacai
Copy link
Collaborator

@ellacai ellacai commented Oct 5, 2023 •
edited
Loading

🛠️ Description

AC:

  • Instead of showing "Searching services" when a user inputs text in the search field update to say "Showing results for
    <inputed search text>"

📸 Screenshots

video1271683456.mp4

🔗 External Links

🏗️ How to Build and Test the Change

👍 Definition of Done

  • New functionality works?
  • Tests added?
  • Docs updated?

💬 Using the Netlify feedback ladder

  • 🗻 [mountain]: Blocking and requires immediate action.
  • 🗿 [boulder]: Blocking.
  • ⚪ [pebble]: Non-blocking, but requires future action.
  • ⏳ [sand]: Non-blocking, but requires future consideration.
  • ✨ [dust]: Non-blocking. "Take it or leave it"

@ellacai ellacai requested a review from a team as a code owner October 5, 2023 18:03
@vercel
Copy link

vercel bot commented Oct 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
consul-ui-toolkit-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 6:25pm

@ellacai ellacai changed the title update filter bar filter status text to include searched text CC-6624: Update FilterBar results text on search Oct 5, 2023
@WenInCode WenInCode merged commit f4df22e into main Oct 5, 2023
14 checks passed
@WenInCode WenInCode deleted the CC-6624 branch October 5, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenInCode WenInCode WenInCode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ellacai @WenInCode