Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC-6796/upgrade hds #83

Merged
merged 4 commits into from
Oct 26, 2023
Merged

CC-6796/upgrade hds #83

merged 4 commits into from
Oct 26, 2023

Conversation

WenInCode
Copy link
Contributor

@WenInCode WenInCode commented Oct 25, 2023

πŸ› οΈ Description

Upgrades to latest @hashicorp/design-system-components release and sets it as a peerdep. Making this a major change due to the peerdep in conjunction with the HDS major change.

πŸ“Έ Screenshots

πŸ”— External Links

https://hashicorp.atlassian.net/browse/CC-6796

πŸ—οΈ How to Build and Test the Change

πŸ‘ Definition of Done

  • New functionality works?
  • Tests added?
  • Docs updated?

πŸ’¬ Using the Netlify feedback ladder

  • πŸ—» [mountain]: Blocking and requires immediate action.
  • πŸ—Ώ [boulder]: Blocking.
  • βšͺ [pebble]: Non-blocking, but requires future action.
  • ⏳ [sand]: Non-blocking, but requires future consideration.
  • ✨ [dust]: Non-blocking. "Take it or leave it"

@WenInCode WenInCode added the pr/no-changeset PR does not need a corresponding .changeset label Oct 25, 2023
@vercel
Copy link

vercel bot commented Oct 25, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
consul-ui-toolkit-documentation βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 26, 2023 0:25am

Copy link
Collaborator

@ellacai ellacai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ lgtm!
left a tiny comment

@@ -11,6 +11,7 @@
<T.Panel>
<div class="doc-Page">
<div class="doc-Page-content">
<Hds::Tag @text="Test tag" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to remove this tag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh holy smokes I though I dropped that commit I must have accidentally squashed it. Thanks!

@WenInCode WenInCode merged commit 5178670 into main Oct 26, 2023
14 checks passed
@WenInCode WenInCode deleted the CC-6796/upgrade-hds branch October 26, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants