New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CC-7195: upgrade deps #90
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
e854a1c
to
18d0698
Compare
913695b
to
5946182
Compare
5946182
to
76803b9
Compare
76803b9
to
4a16532
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good in the vercel preview and the code changes look good from what I can tell! The separate commits really helped for review, thanks!! 💯 🙌
@@ -82,7 +82,7 @@ | |||
"qunit": "^2.20.0", | |||
"qunit-dom": "^3.0.0", | |||
"sass": "^1.60.0", | |||
"sinon": "9.0.1", | |||
"sinon": "17.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9 -> 17 wow!
🛠️ Description
ember-source
even though all consuming apps already have that. It was required byember-concurrency
and our embroider addon did not haveember-source
itself.📸 Screenshots
I've installed the dev build in both cloud and consul using yalc to verify it still works as intended:
In consul, I just inserted a list item with fake data here.
🔗 External Links
CC-7195
🏗️ How to Build and Test the Change
👍 Definition of Done
💬 Using the Netlify feedback ladder