Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC-7195: upgrade deps #90

Merged
merged 33 commits into from Jan 8, 2024
Merged

CC-7195: upgrade deps #90

merged 33 commits into from Jan 8, 2024

Conversation

WenInCode
Copy link
Collaborator

@WenInCode WenInCode commented Dec 22, 2023

🛠️ Description

  • Upgrades all the dependencies, except rollup as the version we are on is required by another dependency
  • Most of the majors were due to dropping node support
  • Adding this as a major change as it does add a peer dependency in ember-source even though all consuming apps already have that. It was required by ember-concurrency and our embroider addon did not have ember-source itself.
  • This PR a lot of changes but the linting changes should be separated into their own commits.
  • Upgrades yarn to use yarn 4. We had to vendor yarn here, similar to what is happening in cloud-ui and design-systems repos.

📸 Screenshots

I've installed the dev build in both cloud and consul using yalc to verify it still works as intended:
Screenshot 2024-01-03 at 11 11 27 AM

In consul, I just inserted a list item with fake data here.
Screenshot 2024-01-03 at 10 49 40 AM

🔗 External Links

CC-7195

🏗️ How to Build and Test the Change

👍 Definition of Done

  • New functionality works?
  • Tests added?
  • Docs updated?

💬 Using the Netlify feedback ladder

  • 🗻 [mountain]: Blocking and requires immediate action.
  • 🗿 [boulder]: Blocking.
  • [pebble]: Non-blocking, but requires future action.
  • [sand]: Non-blocking, but requires future consideration.
  • [dust]: Non-blocking. "Take it or leave it"

@WenInCode WenInCode added the dependencies Pull requests that update a dependency file label Dec 22, 2023
@WenInCode WenInCode requested a review from a team as a code owner December 22, 2023 17:03
Copy link

vercel bot commented Dec 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
consul-ui-toolkit-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2024 5:39pm

Copy link
Collaborator

@natmegs natmegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good in the vercel preview and the code changes look good from what I can tell! The separate commits really helped for review, thanks!! 💯 🙌

package.json Outdated Show resolved Hide resolved
toolkit/package.json Show resolved Hide resolved
@@ -82,7 +82,7 @@
"qunit": "^2.20.0",
"qunit-dom": "^3.0.0",
"sass": "^1.60.0",
"sinon": "9.0.1",
"sinon": "17.0.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9 -> 17 wow!

.changeset/many-worms-doubt.md Show resolved Hide resolved
@WenInCode WenInCode merged commit 5f1d9b0 into main Jan 8, 2024
14 checks passed
@WenInCode WenInCode deleted the CC-7195/upgrade-deps branch January 8, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants