Log replication warnings when no error suppression is defined (#9320)

* Log replication warnings when no error suppression is defined * Add changelog file
hashicorp · Apr 21, 2021 · d802625 · d802625
1 parent 3e7bb52
commit d802625
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/.changelog/9320.txt b/.changelog/9320.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+replication: Correctly log all replication warnings that should not be suppressed
+```
diff --git a/agent/consul/replication.go b/agent/consul/replication.go
@@ -104,7 +104,7 @@ func (r *Replicator) Run(ctx context.Context) error {
 			// the next round of replication
 			atomic.StoreUint64(&r.lastRemoteIndex, 0)
 
-			if r.suppressErrorLog != nil && !r.suppressErrorLog(err) {
+			if r.suppressErrorLog == nil || !r.suppressErrorLog(err) {
 				r.logger.Warn("replication error (will retry if still leader)", "error", err)
 			}