Skip to content

Commit

Permalink
Fix bug with unused (replaced with "") CONSUL_HTTP_AUTH in some places
Browse files Browse the repository at this point in the history
example: https://github.com/hashicorp/consul/blob/master/watch/plan.go#L26

	conf := consulapi.DefaultConfig()
	conf.Address = address
	conf.Datacenter = p.Datacenter
	conf.Token = p.Token                             # <-- replace Token from DefaultConfig/CONSUL_HTTP_AUTH with ""
	client, err := consulapi.NewClient(conf)

how to reproduce bug:
0. consul -> localhost:8500 with more than 0 service checks
1. deny all for anonymous token
2. create appropriate acl <token> for watch checks (agent:read + node:read,service:read)
3. bash:
CONSUL_HTTP_AUTH=<token> consul watch -http-addr=localhost:8500 -type=checks # --> return []
consul watch -http-addr=localhost:8500 -type=checks -token=<token> # -> return { .... right json result .... }
  • Loading branch information
Illirgway committed Aug 15, 2017
1 parent 546ffc2 commit e0cc1ce
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions api/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,10 @@ func NewClient(config *Config) (*Client, error) {
config.Address = parts[1]
}

if config.Token == "" {
config.Token = defConfig.Token
}

client := &Client{
config: *config,
}
Expand Down

0 comments on commit e0cc1ce

Please sign in to comment.