ui: Add TProxy Mode notice banner to service instance Upstreams tab #10136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johncowen
reviewed
Apr 28, 2021
| @internal={{false}} | ||
| @action={{true}} | ||
| /> | ||
| {{/if}} |
There was a problem hiding this comment.
I'd prefer to use a normal <Notice /> component here, (then we keep the h3 etc in the top level route template) would it be ok to change that out?
There was a problem hiding this comment.
@johncowen Updated to use <Notice />
kaxcode
force-pushed
the
ui/featurea/add-tproxy-banner-to-upstreams-tab
branch
from
068cdbb
to
e63697e
Compare
mikemorris
pushed a commit
that referenced
this pull request
May 5, 2021
mikemorris
pushed a commit
that referenced
this pull request
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a "warning" notice at the top of the service instance upstream tab. This gives the user more information about the upstreams list rendered.