http: set consistency header properly for health endpoint #10189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
force-pushed
the
dnephin/http-api-health-query-meta
branch
from
4a09415
to
f8260f8
Compare
A recent change in 1.9.x inverted the order of these two lines, which caused the X-Consul-Effective-Consistency header to be missing for the servie health endpoints
dnephin
force-pushed
the
dnephin/http-api-health-query-meta
branch
from
f8260f8
to
0575ca6
Compare
jsosulska
approved these changes
May 6, 2021
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/364305. |
|
🍒✅ Cherry pick of commit 850c6e5 onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
May 6, 2021
…y-meta http: set consistency header properly for health endpoint
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/364425. |
|
🍒✅ Cherry pick of commit 850c6e5 onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
May 6, 2021
…y-meta http: set consistency header properly for health endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change in 1.9.x inverted the order of these two lines, which caused the
X-Consul-Effective-Consistencyheader to be missing for the service health endpoints.