-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http: set consistency header properly for health endpoint #10189
Conversation
4a09415
to
f8260f8
Compare
A recent change in 1.9.x inverted the order of these two lines, which caused the X-Consul-Effective-Consistency header to be missing for the servie health endpoints
f8260f8
to
0575ca6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for catching this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/364305. |
🍒✅ Cherry pick of commit 850c6e5 onto |
…y-meta http: set consistency header properly for health endpoint
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/364425. |
🍒✅ Cherry pick of commit 850c6e5 onto |
…y-meta http: set consistency header properly for health endpoint
A recent change in 1.9.x inverted the order of these two lines, which caused the
X-Consul-Effective-Consistency
header to be missing for the service health endpoints.