Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Fix Health Checks in K/V form Lock Sessions Info section #10767

Merged
merged 4 commits into from Aug 4, 2021

Conversation

kaxcode
Copy link
Contributor

@kaxcode kaxcode commented Aug 4, 2021

Description:

Resolves #10754. The ServiceChecks attribute formatting was outdated in the Lock Session endpoint API docs and in the UI mock data.

Demo Link

Solution:

Screenshots:

Before:
Screen Shot 2021-08-04 at 9 18 34 AM

After:
Screen Shot 2021-08-04 at 9 11 25 AM

Testing:

No additional testing. This change was not about integration, but on reading the response properly.

  • Backport
  • Changelog
  • Demo Link

@kaxcode kaxcode added theme/ui Anything related to the UI backport/1.9 labels Aug 4, 2021
@kaxcode kaxcode requested review from gsusmi and a user August 4, 2021 14:27
@vercel vercel bot temporarily deployed to Preview – consul August 4, 2021 14:30 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging August 4, 2021 14:30 Inactive
@kaxcode kaxcode merged commit 8ad1ab9 into main Aug 4, 2021
@kaxcode kaxcode deleted the ui/bug/sessions-health-checks branch August 4, 2021 16:41
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/420973.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 8ad1ab9 onto release/1.10.x succeeded!

@hc-github-team-consul-core
Copy link
Collaborator

🍒❌ Cherry pick of commit 8ad1ab9 onto release/1.9.x failed! Build Log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service checks are not shown in lock session summary
2 participants