Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: [BUGFIX] Add missing @ to fix missing non-subset Failovers #10913

Merged
merged 2 commits into from Aug 26, 2021

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented Aug 26, 2021

This PR fixes a problem where parent Failovers where not showing (subset children were fine).

Thanks @Ranjandas for pinging us with this one. 0@0 👍

(I still need to trace back where to backport this to and changelog)

Seems to have been introduced with a move/glimmer upgrade here #9154 so I'm adding a 1.9.x backport.

@johncowen johncowen added the theme/ui Anything related to the UI label Aug 26, 2021
@johncowen johncowen requested a review from kaxcode August 26, 2021 09:29
Copy link
Contributor

@kaxcode kaxcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging August 26, 2021 15:53 Inactive
@vercel vercel bot temporarily deployed to Preview – consul August 26, 2021 15:53 Inactive
@johncowen johncowen merged commit a0b0ed2 into main Aug 26, 2021
@johncowen johncowen deleted the ui/bugfix/disco-chain-failover-typo branch August 26, 2021 16:01
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/434145.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit a0b0ed2 onto release/1.10.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Aug 26, 2021
)

This commit fixes a problem where parent Failovers where not showing (subset children were fine).

Seems to have been introduced with a move/glimmer upgrade here #9154 so I'm adding a 1.9.x backport.
@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit a0b0ed2 onto release/1.9.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Aug 26, 2021
)

This commit fixes a problem where parent Failovers where not showing (subset children were fine).

Seems to have been introduced with a move/glimmer upgrade here #9154 so I'm adding a 1.9.x backport.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/ui Anything related to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants