ui: Move DiscoveryChain component #9154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍒 Starting backport cherry picking. To cherry-pick post-merge, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/277978. |
|
🍒 Starting backport cherry picking. To cherry-pick post-merge, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/278014. |
|
🍒✅ Cherry pick of commit e1d9771 onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Nov 11, 2020
johncowen
added a commit
that referenced
this pull request
Aug 26, 2021
) This commit fixes a problem where parent Failovers where not showing (subset children were fine). Seems to have been introduced with a move/glimmer upgrade here #9154 so I'm adding a 1.9.x backport.
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
Aug 26, 2021
) This commit fixes a problem where parent Failovers where not showing (subset children were fine). Seems to have been introduced with a move/glimmer upgrade here #9154 so I'm adding a 1.9.x backport.
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
Aug 26, 2021
) This commit fixes a problem where parent Failovers where not showing (subset children were fine). Seems to have been introduced with a move/glimmer upgrade here #9154 so I'm adding a 1.9.x backport.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the discovery-chain component and related files into consul/discovery-chain.
We also took the opportunity to remove the old IntersectionObserver code here that we used to use to initialize the visualization previous to us having linked tabs (previously we used CSS to hide show tabs), and also update the simpler sub components to use glimmer components. The main component is a little more heavy lift to upgrade to glimmer so we left that for another time.