ui: upgrade ember composable helper #13394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes `sort-by` performance regression * Includes `pick`-helper for easier composition with Octane
`contains` is removed in ember-composable-helpers@5.x
johncowen
reviewed
Jun 8, 2022
There was a problem hiding this comment.
Oh amazing, so excited for this to go in. There are a few helpers I've been wanting to use that are only "in later than 4" versions 🎉
I spotted a couple more references to contains in the packages/consul-* folders (nspaces, lock-sessions, partitions). If we can fix those up also and we can get this in!
Oh, did you manage to check the performance of sorting on 10s of thousands of rows to make sure its as quick as the 4.0.0 sort-by?
LevelbossMike
changed the title
johncowen
approved these changes
Jun 8, 2022
thanks again for doing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade ember-composable-helpers to version 5.x. This version contains the
pick-helper which makes composition in the template layer easier with Octane.Version 5.x also fixes a regression with
sort-bythat according to @johncowen was the reason why the version was pinned to4.0.0at the moment.Version 5 of
ember-composable-helpersremoves thecontains-helper in favor ofincludeswhich I changed all occurences for.Testing & Reproduction steps
Tests are passing locally.
Links
Fix for slow sort-by - PR